Messages in this thread | | | From | Namhyung Kim <> | Subject | [PATCH/RFC 0/3] perf ui/gtk: Separate out GTK code to a shared object (v3) | Date | Thu, 8 Aug 2013 15:34:07 +0900 |
| |
Hi,
This is v3 of gtk code separation patchset to reduce library dependencies of the perf executable.
I only built libperf-gtk.so with -fPIC, and it's not linked to libperf at build time. All unresolved symbols used for perf should be resolved at runtime via perf executable (so libperf.a) - I didn't know that the linker permits unresolved symbols in a shared library at build time.
Tested on my x86-64 machine only. It seems work well for me.
v3 changes: * fix build failure on O= option * fix build failure on NO_GTK2= option * add Reviewed-by tag from Pekka * patch 1 of previous series already merged
You can find it on my 'perf/separate-v3' branch in my tree at:
git://git.kernel.org/pub/scm/linux/kernel/git/namhyung/linux-perf.git
Any comments are welcome, thanks Namhyung
Cc: Pekka Enberg <penberg@kernel.org> Cc: Andi Kleen <andi@firstfloor.org>
Namhyung Kim (3): perf tools: Separate out GTK codes to libperf-gtk.so perf tools: Setup GTK browser dynamically perf tools: Run dynamic loaded GTK browser
tools/perf/Makefile | 39 +++++++++++++++++++++++---------- tools/perf/builtin-annotate.c | 26 +++++++++++++++++++--- tools/perf/builtin-report.c | 16 ++++++++++++-- tools/perf/config/Makefile | 12 ++++++++--- tools/perf/ui/gtk/annotate.c | 13 ++++++++--- tools/perf/ui/gtk/gtk.h | 16 ++++++++++++++ tools/perf/ui/setup.c | 50 +++++++++++++++++++++++++++++++++++++++++-- tools/perf/ui/ui.h | 12 +---------- tools/perf/util/annotate.h | 24 --------------------- tools/perf/util/hist.h | 15 ------------- 10 files changed, 149 insertions(+), 74 deletions(-)
-- 1.7.11.7
| |