Messages in this thread | | | Subject | regulator: s2mps11: Question about the code updating ramp_delay setting | From | Axel Lin <> | Date | Sat, 03 Aug 2013 17:13:08 +0800 |
| |
Hi Yadwinder, The code updating ramp_delay setting looks wrong to me.
Current code: return regmap_update_bits(rdev->regmap, ramp_reg, ramp_val << ramp_shift, 1 << ramp_shift); I'd expect something like below: return regmap_update_bits(rdev->regmap, ramp_reg, ramp_mask << ramp_shift, ramp_val << ramp_shift); I don't have the datasheet so I don't know the correct ramp_mask setting here. Can you check if this needs fix?
Thanks, Axel
| |