Messages in this thread | | | Subject | Re: [PATCH V5] gpio: New driver for LSI ZEVIO SoCs | Date | Thu, 29 Aug 2013 22:28:56 +0200 | From | "Fabian Vogt" <> |
| |
> On 08/26/2013 12:18 PM, Fabian Vogt wrote: >> This driver supports the GPIO controller found in LSI ZEVIO SoCs. >> It has been successfully tested on a TI nspire CX calculator.
> What changed in v5 (or indeed any other versions?)
> Repeating what Stephen said, can you please provide a changelog? > I need an overview of what changed over time. > > Yours, > Linus Walleij Oh, ok.
V2: Mail client had bug I didn't notice, resend with git send-email V3: Noticed that git send-email did not invoke cleanpatch V4: Changed uint*_t to u*, renamed "sticky IRQ" to "level IRQ" V5: Removed #ngpios V6 (coming): Mark Rutlands suggestions (Don't free devm allocated memory, readable macros) and a description of the changes
>> diff --git a/Documentation/devicetree/bindings/gpio/gpio-zevio.txt >> b/Documentation/devicetree/bindings/gpio/gpio-zevio.txt > >> +Zevio GPIO controller >> + >> +Required properties: >> +- compatible = "lsi,zevio-gpio" >> +- reg = <BASEADDR SIZE> >Perhaps this should say: >reg: Contains a single register specifier for the GPIO module's > registers.
reg = Register specifier for the location and size of the GPIO controller's registers.
>> +- #gpio-cells = <2> >This should describe what those cells are. For example perhaps: > > #gpio-cells. Must be 2. The first cell is the GPIO number. The second > cell is used to specify optional parameters: > - bit 0 specifies polarity (0 for normal, 1 for inverted) "Must be 2. The second cell is ... optional"?
| |