Messages in this thread | | | Date | Tue, 27 Aug 2013 14:09:39 -0600 | From | Stephen Warren <> | Subject | Re: [PATCH V5] gpio: New driver for LSI ZEVIO SoCs |
| |
On 08/26/2013 12:18 PM, Fabian Vogt wrote: > This driver supports the GPIO controller found in LSI ZEVIO SoCs. > It has been successfully tested on a TI nspire CX calculator.
What changed in v5 (or indeed any other versions?)
> diff --git a/Documentation/devicetree/bindings/gpio/gpio-zevio.txt b/Documentation/devicetree/bindings/gpio/gpio-zevio.txt
> +Zevio GPIO controller > + > +Required properties: > +- compatible = "lsi,zevio-gpio" > +- reg = <BASEADDR SIZE>
Perhaps this should say:
reg: Contains a single register specifier for the GPIO module's registers.
> +- #gpio-cells = <2>
This should describe what those cells are. For example perhaps:
#gpio-cells. Must be 2. The first cell is the GPIO number. The second cell is used to specify optional parameters: - bit 0 specifies polarity (0 for normal, 1 for inverted)
| |