Messages in this thread | | | Date | Tue, 27 Aug 2013 17:05:35 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH] proc: make proc_fd_permission() thread-friendly |
| |
On 08/26, Willy Tarreau wrote: > > On Mon, Aug 26, 2013 at 12:35:26PM -0700, Linus Torvalds wrote: > (...) > > Yes, it would be semantically different, but it would mean that > > "/proc/self/fd/" would actually make sense in a way that it currently > > does *not* - which would seem fairly important, since the primary use > > for it tends to be /dev/stdin. > > I remember another user, don't know if that has changed. UPX used to build > self-extract binaries that opened /proc/self/fd/3.
But /proc/<tgid>/fd and /proc/<tid>/fd should be the same. Unless it plays with unshare() or clone(CLONE_THREAD /* no CLONE_FILES */).
Unlike, but:
> because it's typically a usage that > could be discovered to be broken months after the change!
Oh yes, I agree. This change is trivial but nasty, god knows what people actually do with /proc/self.
Oleg.
| |