Messages in this thread | | | Date | Tue, 27 Aug 2013 19:49:16 +0200 | From | Oleg Nesterov <> | Subject | Re: [PATCH 1/1] proc: make /proc/self point to thread |
| |
On 08/27, Linus Torvalds wrote: > > On Tue, Aug 27, 2013 at 7:40 AM, Oleg Nesterov <oleg@redhat.com> wrote: > > /proc/self points to /proc/<tgid>, not to /proc/<tid>, and thus > > "self" actually means "group leader". > > > > Change fs/proc/self.c to print the caller's tid, this is probably > > what the users actually expect. > > Yeah, thinking more about this, this can't work. I think you'd need to > use "/proc/<tgid>/task/<tid>" wouldn't you?
Why? To me /proc/self == /proc/$((sys_gettid)) looks more natural. Say, /proc/self/task... But this is subjective.
Not to mention, that would be much more visible change.
> Anyway, does not not sound worth it. Your previous simple patch is > probably the right thing to do.
OK, lets forget it.
Although to be honest, I was seduced by "Worth testing". I mean I am just curious, who can suffer from this change? Nevermind, please ignore.
Oleg.
| |