Messages in this thread - First message in thread
- "Lee, Chun-Yi"
- "Lee, Chun-Yi"
- "Lee, Chun-Yi"
- "Lee, Chun-Yi"
- "Lee, Chun-Yi"
- "Lee, Chun-Yi"
- "Lee, Chun-Yi"
- "Lee, Chun-Yi"
- "Lee, Chun-Yi"
- "Lee, Chun-Yi"
- "Lee, Chun-Yi"
- "Lee, Chun-Yi"
- "Lee, Chun-Yi"
- "Lee, Chun-Yi"
- "Lee, Chun-Yi"
- "Lee, Chun-Yi"
- "Lee, Chun-Yi"
- "Lee, Chun-Yi"
- "Lee, Chun-Yi"
- Florian Weimer
| | | Date | Sun, 25 Aug 2013 18:10:12 +0200 | From | Pavel Machek <> | Subject | Re: [PATCH 06/18] asymmetric keys: support parsing PKCS #8 private key information |
| |
On Thu 2013-08-22 19:01:45, Lee, Chun-Yi wrote: > Add ASN.1 files and parser to support parsing PKCS #8 noncompressed private > key information. It's better than direct parsing pure private key because > PKCS #8 has a privateKeyAlgorithm to indicate the algorithm of private > key, e.g. RSA from PKCS #1 > > Reviewed-by: Jiri Kosina <jkosina@suse.cz> > Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
> +#include <crypto/public_key.h> > + > +struct pkcs8_info { > + enum pkey_algo privkey_algo:8; /* Private key algorithm */
Are you sure this is well-defined?
> +struct private_key_algorithm *pkcs8_private_key_algorithms[PKEY_ALGO__LAST] = { > + [PKEY_ALGO_DSA] = NULL, > +#if defined(CONFIG_PUBLIC_KEY_ALGO_RSA) || \ > + defined(CONFIG_PUBLIC_KEY_ALGO_RSA_MODULE) > + [PKEY_ALGO_RSA] = &RSA_private_key_algorithm, > +#endif > +};
pkey_algo privkey_algo private_key_algorithm
...you use all variants.
Having symbols with "__" inside them is "interesting". I'd not do it. Pavel
-- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
| |