lkml.org 
[lkml]   [2013]   [Aug]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 17/18] Hibernate: introduced SNAPSHOT_SIG_HASH config for select hash algorithm
    On Thu 2013-08-22 19:01:56, Lee, Chun-Yi wrote:
    > This patch introduced SNAPSHOT_SIG_HASH config for user to select which
    > hash algorithm will be used during signature generation of snapshot.
    >
    > v2:
    > Add define check of oCONFIG_SNAPSHOT_VERIFICATION in snapshot.c before
    > declare pkey_hash().
    >
    > Reviewed-by: Jiri Kosina <jkosina@suse.cz>
    > Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
    > ---
    > kernel/power/Kconfig | 46 ++++++++++++++++++++++++++++++++++++++++++++++
    > kernel/power/snapshot.c | 27 ++++++++++++++++++++++-----
    > 2 files changed, 68 insertions(+), 5 deletions(-)
    >
    > diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig
    > index b592d88..79b34fa 100644
    > --- a/kernel/power/Kconfig
    > +++ b/kernel/power/Kconfig
    > @@ -78,6 +78,52 @@ config SNAPSHOT_VERIFICATION
    > dependent on UEFI environment. EFI bootloader should generate the
    > key-pair.
    >
    > +choice
    > + prompt "Which hash algorithm should snapshot be signed with?"
    > + depends on SNAPSHOT_VERIFICATION
    > + help
    > + This determines which sort of hashing algorithm will be used during
    > + signature generation of snapshot. This algorithm _must_ be built into
    > + the kernel directly so that signature verification can take place.
    > + It is not possible to load a signed snapshot containing the algorithm
    > + to check the signature on that module.

    Like if 1000 ifdefs you already added to the code are not enough, you
    make some new ones?
    Pavel

    --
    (english) http://www.livejournal.com/~pavelmachek
    (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html


    \
     
     \ /
      Last update: 2013-08-25 19:01    [W:5.402 / U:0.604 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site