Messages in this thread Patch in this message | | | Date | Thu, 22 Aug 2013 09:48:59 +0800 | From | Wang Sheng-Hui <> | Subject | [PATCH] tile: add null check for kzalloc in tile/kernel/setup.c |
| |
Should check the return value of kzalloc first to avoid the null pointer. Then can dereference the non-null pointer to access the fields of struct resource.
Signed-off-by: Wang Sheng-Hui <shhuiw@gmail.com> --- arch/tile/kernel/setup.c | 4 ++++ 1 file changed, 4 insertions(+)
diff --git a/arch/tile/kernel/setup.c b/arch/tile/kernel/setup.c index eceb834..7d4138c 100644 --- a/arch/tile/kernel/setup.c +++ b/arch/tile/kernel/setup.c @@ -1548,6 +1548,8 @@ insert_non_bus_resource(void) { struct resource *res = kzalloc(sizeof(struct resource), GFP_ATOMIC); + if (!res) + return NULL; res->name = "Non-Bus Physical Address Space"; res->start = (1ULL << 32); res->end = -1LL; @@ -1565,6 +1567,8 @@ insert_ram_resource(u64 start_pfn, u64 end_pfn) { struct resource *res = kzalloc(sizeof(struct resource), GFP_ATOMIC); + if (!res) + return NULL; res->name = "System RAM"; res->start = start_pfn << PAGE_SHIFT; res->end = (end_pfn << PAGE_SHIFT) - 1; -- 1.7.10.4
| |