Messages in this thread | | | Date | Wed, 21 Aug 2013 15:03:37 -0700 | From | Andrew Morton <> | Subject | Re: [PATCH 2/3] mm/shmem.c: let shmem_show_mpol() return value. |
| |
On Wed, 21 Aug 2013 10:23:58 +0800 Chen Gang <gang.chen@asianux.com> wrote:
> Let shmem_show_mpol() return value, since it may fail. >
This patch has no effect.
> --- a/mm/shmem.c > +++ b/mm/shmem.c > @@ -883,16 +883,17 @@ redirty: > > #ifdef CONFIG_NUMA > #ifdef CONFIG_TMPFS > -static void shmem_show_mpol(struct seq_file *seq, struct mempolicy *mpol) > +static int shmem_show_mpol(struct seq_file *seq, struct mempolicy *mpol) > { > char buffer[64]; > > if (!mpol || mpol->mode == MPOL_DEFAULT) > - return; /* show nothing */ > + return 0; /* show nothing */ > > mpol_to_str(buffer, sizeof(buffer), mpol);
Perhaps you meant to check the mpol_to_str() return value here.
> seq_printf(seq, ",mpol=%s", buffer); > + return 0; > } > > static struct mempolicy *shmem_get_sbmpol(struct shmem_sb_info *sbinfo)
| |