Messages in this thread Patch in this message | | | Date | Wed, 21 Aug 2013 10:24:58 +0800 | From | Chen Gang <> | Subject | [PATCH 3/3] mm/shmem.c: check the return value of mpol_to_str() |
| |
mpol_to_str() may fail, and not fill the buffer (e.g. -EINVAL), so need check about it, or buffer may not be zero based, and next seq_printf() will cause issue.
Signed-off-by: Chen Gang <gang.chen@asianux.com> Cc: Cyrill Gorcunov <gorcunov@gmail.com> --- mm/shmem.c | 5 ++++- 1 files changed, 4 insertions(+), 1 deletions(-)
diff --git a/mm/shmem.c b/mm/shmem.c index e59d332..ae5112f 100644 --- a/mm/shmem.c +++ b/mm/shmem.c @@ -886,11 +886,14 @@ redirty: static int shmem_show_mpol(struct seq_file *seq, struct mempolicy *mpol) { char buffer[64]; + int ret; if (!mpol || mpol->mode == MPOL_DEFAULT) return 0; /* show nothing */ - mpol_to_str(buffer, sizeof(buffer), mpol); + ret = mpol_to_str(buffer, sizeof(buffer), mpol); + if (ret < 0) + return ret; seq_printf(seq, ",mpol=%s", buffer); return 0; -- 1.7.7.6
| |