Messages in this thread | | | Date | Fri, 02 Aug 2013 10:23:49 -0500 | From | Mark Langsdorf <> | Subject | Re: [PATCH 1/5] sata, highbank: fix ordering of SGPIO signals |
| |
On 07/29/2013 11:55 AM, Tejun Heo wrote: > On Fri, Jul 26, 2013 at 10:11:54AM -0500, Mark Langsdorf wrote: >> The ACTIVITY and ERROR signals were reversed in the original commit. >> Fix that. > > And what's the implication of this change? Does this change the > behavior of the driver? If so, how? If not, why not? *Please* be > more descriptive in patch descriptions and explain *why* the changes > are being made.
I didn't think I needed more of an explanation than "this is completely wrong per the spec" but I'll revise and resubmit.
--Mark Langsdorf Calxeda, Inc.
| |