Messages in this thread | | | Subject | Re: [PATCH 5/6] acpi: Check if @id is NULL in acpi_table_parse() | From | Toshi Kani <> | Date | Mon, 19 Aug 2013 13:29:03 -0600 |
| |
On Fri, 2013-08-16 at 15:06 +0800, Tang Chen wrote: > strncmp() does not check if the params are NULL. In acpi_table_parse(), > if @id is NULL, the kernel will panic. > > Signed-off-by: Tang Chen <tangchen@cn.fujitsu.com>
Acked-by: Toshi Kani <toshi.kani@hp.com>
-Toshi
> --- > drivers/acpi/tables.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/drivers/acpi/tables.c b/drivers/acpi/tables.c > index d67a1fe..5a5263b 100644 > --- a/drivers/acpi/tables.c > +++ b/drivers/acpi/tables.c > @@ -293,7 +293,7 @@ int __init acpi_table_parse(char *id, acpi_tbl_table_handler handler) > if (acpi_disabled) > return -ENODEV; > > - if (!handler) > + if (!id || !handler) > return -EINVAL; > > if (strncmp(id, ACPI_SIG_MADT, 4) == 0)
| |