Messages in this thread | | | Date | Fri, 16 Aug 2013 15:58:44 +0800 | From | Tang Chen <> | Subject | Re: [PATCH 3/6] acpi cleanup: Use pr_info() instead of printk() in arch/x86/mm/srat.c |
| |
Hi Joe,
On 08/16/2013 03:25 PM, Joe Perches wrote: > On Fri, 2013-08-16 at 15:06 +0800, Tang Chen wrote: >> arch/x86/mm/srat.c > > I think it'd be better to use pr_fmt > with the conversions to pr_info and pr_err. > > pr_fmt can prefix the appropriate srat: and > so the format strings do not need it. > > Something like: > --- > arch/x86/mm/srat.c | 31 ++++++++++++++++--------------- > 1 file changed, 16 insertions(+), 15 deletions(-) > > diff --git a/arch/x86/mm/srat.c b/arch/x86/mm/srat.c > index cdd0da9..350b4c5 100644 > --- a/arch/x86/mm/srat.c > +++ b/arch/x86/mm/srat.c > @@ -9,6 +9,8 @@ > * are in one chunk. Holes between them will be included in the node. > */ > > +#define pr_fmt(fmt) KBUILD_MODNAME ": " fmt
OK, will update the patches.
Thanks. :)
| |