Messages in this thread | | | Date | Fri, 16 Aug 2013 20:42:29 +0300 | Subject | Re: [PATCH 2/2] xhci:prevent "callbacks suppressed" when debug is not enabled | From | Dmitry Kasatkin <> |
| |
On Fri, Aug 16, 2013 at 8:38 PM, Sarah Sharp <sarah.a.sharp@linux.intel.com> wrote: > On Fri, Aug 16, 2013 at 10:30:35AM -0700, Greg KH wrote: >> On Fri, Aug 16, 2013 at 10:26:35AM -0700, Sarah Sharp wrote: >> > On Thu, Aug 15, 2013 at 05:17:16PM -0700, Greg KH wrote: >> > > On Thu, Aug 15, 2013 at 07:04:55PM +0300, Dmitry Kasatkin wrote: >> > > > When debug is not enabled and dev_dbg() will expand to nothing, >> > > > log might be flooded with "callbacks suppressed". If it was not >> > > > done on purpose, better to use dev_dbg_ratelimited() instead. >> > > > >> > > > Signed-off-by: Dmitry Kasatkin <d.kasatkin@samsung.com> >> > > > --- >> > > > drivers/usb/host/xhci-ring.c | 6 ++---- >> > > > 1 file changed, 2 insertions(+), 4 deletions(-) >> > > >> > > >> > > Sarah, does this patch conflict with the trace debug patches being >> > > worked on? I'll hold off on applying it for now, let me know if it's ok >> > > or not. >> > >> > It doesn't conflict with the trace debug patches, because those only >> > effect debugging with xhci_dbg with the host device, not dev_dbg with >> > the USB device. This should apply fine to usb-next. >> >> Ok, can I get your ack for it so I can apply it? > > Dmitry, can you fix the indentation issue and resubmit this? I'll ack > it then. > > Sarah Sharp
Sure.
Thanks Dmitry
| |