Messages in this thread | | | Date | Thu, 15 Aug 2013 17:17:16 -0700 | From | Greg KH <> | Subject | Re: [PATCH 2/2] xhci:prevent "callbacks suppressed" when debug is not enabled |
| |
On Thu, Aug 15, 2013 at 07:04:55PM +0300, Dmitry Kasatkin wrote: > When debug is not enabled and dev_dbg() will expand to nothing, > log might be flooded with "callbacks suppressed". If it was not > done on purpose, better to use dev_dbg_ratelimited() instead. > > Signed-off-by: Dmitry Kasatkin <d.kasatkin@samsung.com> > --- > drivers/usb/host/xhci-ring.c | 6 ++---- > 1 file changed, 2 insertions(+), 4 deletions(-)
Sarah, does this patch conflict with the trace debug patches being worked on? I'll hold off on applying it for now, let me know if it's ok or not.
thanks,
greg k-h > > diff --git a/drivers/usb/host/xhci-ring.c b/drivers/usb/host/xhci-ring.c > index 5b08cd8..5298232 100644 > --- a/drivers/usb/host/xhci-ring.c > +++ b/drivers/usb/host/xhci-ring.c > @@ -3060,8 +3060,7 @@ int xhci_queue_intr_tx(struct xhci_hcd *xhci, gfp_t mem_flags, > * to set the polling interval (once the API is added). > */ > if (xhci_interval != ep_interval) { > - if (printk_ratelimit()) > - dev_dbg(&urb->dev->dev, "Driver uses different interval" > + dev_dbg_ratelimited(&urb->dev->dev, "Driver uses different interval" > " (%d microframe%s) than xHCI " > "(%d microframe%s)\n", > ep_interval, > @@ -3849,8 +3848,7 @@ int xhci_queue_isoc_tx_prepare(struct xhci_hcd *xhci, gfp_t mem_flags, > * to set the polling interval (once the API is added). > */ > if (xhci_interval != ep_interval) { > - if (printk_ratelimit()) > - dev_dbg(&urb->dev->dev, "Driver uses different interval" > + dev_dbg_ratelimited(&urb->dev->dev, "Driver uses different interval" > " (%d microframe%s) than xHCI " > "(%d microframe%s)\n", > ep_interval, > -- > 1.8.1.2
| |