| From | Luis Henriques <> | Subject | [PATCH 65/75] ALSA: usb/6fire: Fix potential NULL pointer dereference in comm.c | Date | Wed, 14 Aug 2013 11:36:54 +0100 |
| |
3.5.7.19 -stable review patch. If anyone has any objections, please let me know.
------------------
From: Sachin Kamat <sachin.kamat@linaro.org>
commit 27b2a22c714303d1920e269a8322ff23107694ee upstream.
'rt' was dereferenced before the NULL check. Moved the code after the check.
Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org> Signed-off-by: Takashi Iwai <tiwai@suse.de> Signed-off-by: Luis Henriques <luis.henriques@canonical.com> --- sound/usb/6fire/comm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/sound/usb/6fire/comm.c b/sound/usb/6fire/comm.c index 6c3d531..1a75c36 100644 --- a/sound/usb/6fire/comm.c +++ b/sound/usb/6fire/comm.c @@ -129,12 +129,13 @@ int __devinit usb6fire_comm_init(struct sfire_chip *chip) { struct comm_runtime *rt = kzalloc(sizeof(struct comm_runtime), GFP_KERNEL); - struct urb *urb = &rt->receiver; + struct urb *urb; int ret; if (!rt) return -ENOMEM; + urb = &rt->receiver; rt->serial = 1; rt->chip = chip; usb_init_urb(urb); -- 1.8.3.2
|