lkml.org 
[lkml]   [2013]   [Aug]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 37/75] ALSA: compress: fix the return value for SNDRV_COMPRESS_VERSION
    Date
    3.5.7.19 -stable review patch.  If anyone has any objections, please let me know.

    ------------------

    From: Vinod Koul <vinod.koul@intel.com>

    commit a8d30608eaed6cc759b8e2e8a8bbbb42591f797f upstream.

    the return value of SNDRV_COMPRESS_VERSION always return default -ENOTTY as the
    return value was never updated for this call
    assign return value from put_user()

    Reported-by: Haynes <hgeorge@codeaurora.org>
    Signed-off-by: Vinod Koul <vinod.koul@intel.com>
    Signed-off-by: Takashi Iwai <tiwai@suse.de>
    Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
    ---
    sound/core/compress_offload.c | 2 +-
    1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c
    index 54b422e..956c75d 100644
    --- a/sound/core/compress_offload.c
    +++ b/sound/core/compress_offload.c
    @@ -584,7 +584,7 @@ static long snd_compr_ioctl(struct file *f, unsigned int cmd, unsigned long arg)
    mutex_lock(&stream->device->lock);
    switch (_IOC_NR(cmd)) {
    case _IOC_NR(SNDRV_COMPRESS_IOCTL_VERSION):
    - put_user(SNDRV_COMPRESS_VERSION,
    + retval = put_user(SNDRV_COMPRESS_VERSION,
    (int __user *)arg) ? -EFAULT : 0;
    break;
    case _IOC_NR(SNDRV_COMPRESS_GET_CAPS):
    --
    1.8.3.2


    \
     
     \ /
      Last update: 2013-08-14 13:21    [W:3.350 / U:0.612 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site