lkml.org 
[lkml]   [2013]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
Subject[PATCH] fix a Sparse warning in the arch/x86/kernel/irq_work.c file
From
I am a high school student trying to become familiar with the
opensource process and linux kernel. This is my first submission to
the ITC mailing list.

My patch is for the file arch/x86/kernel/irq_work.c in the vesion
linux-3.10 kernel. When I ran the kernel with Sparse, the error read:
arch/x86/kernel/irq_work.c:21:
6: warning: symbol 'arch_irq_work_raise'
was not declared. Should it be static?

To fix this (rather than add static) I declared the symbol in the
header file linux/irq_work.h. Afterwards, my error did not show up
when I ran the kernel with Sparse again. I also ran the command "make
menuconfig" to change the kernel version so that I could assure the
correct kernel was running when I tested it, and it was. Then I test
built the kernel. It built and rebooted correctly.

Signed-off-by: Shailaja Neelam <neelamshaila@gmail.com>
---
--- linux-3.10/include/linux/irq_
work.h 2013-06-30 15:13:29.000000000 -0700
+++ linux-3.10.change/include/linux/irq_work.h 2013-07-24
12:06:15.521140635 -0700
@@ -33,6 +33,7 @@ void init_irq_work(struct irq_work *work
void irq_work_queue(struct irq_work *work);
void irq_work_run(void);
void irq_work_sync(struct irq_work *work);
+void arch_irq_work_raise(void);

#ifdef CONFIG_IRQ_WORK
bool irq_work_needs_cpu(void);

\
 
 \ /
  Last update: 2013-08-13 00:41    [W:0.104 / U:0.152 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site