Messages in this thread | | | Date | Mon, 12 Aug 2013 13:23:56 -0700 | From | Greg Kroah-Hartman <> | Subject | Re: [PATCH] tilegx: Add tty serial support for TILE-Gx on-chip UART |
| |
On Mon, Aug 12, 2013 at 02:56:37PM -0400, Chris Metcalf wrote: > On 8/12/2013 2:43 PM, Greg Kroah-Hartman wrote: > > On Mon, Aug 12, 2013 at 02:11:44PM -0400, Chris Metcalf wrote: > >> +/* > >> + * Enable modem status interrupts. > >> + */ > >> +static void tilegx_enable_ms(struct uart_port *port) > >> +{ > >> + /* N/A */ > >> +} > >> + > >> +/* > >> + * Control the transmission of a break signal. > >> + */ > >> +static void tilegx_break_ctl(struct uart_port *port, int break_state) > >> +{ > >> + /* N/A */ > >> +} > > For most of these "empty" callbacks, you shouldn't have to declare them > > at all, and all should work just fine. > > I may be missing something, but it looks like drivers/tty/serial/serial_core.c > calls all of the "empty" callbacks unconditionally, so some definition > is required.
Ah, you are right, I was looking at the "raw" tty driver, not the uart driver, my mistake.
greg k-h
| |