lkml.org 
[lkml]   [2013]   [Aug]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] tilegx: Add tty serial support for TILE-Gx on-chip UART
On Mon, Aug 12, 2013 at 02:11:44PM -0400, Chris Metcalf wrote:
> +/*
> + * Enable modem status interrupts.
> + */
> +static void tilegx_enable_ms(struct uart_port *port)
> +{
> + /* N/A */
> +}
> +
> +/*
> + * Control the transmission of a break signal.
> + */
> +static void tilegx_break_ctl(struct uart_port *port, int break_state)
> +{
> + /* N/A */
> +}

For most of these "empty" callbacks, you shouldn't have to declare them
at all, and all should work just fine.

Other than that minor nit, at first glance this looks fine to me.

Acked-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>


\
 
 \ /
  Last update: 2013-08-12 21:21    [W:1.804 / U:0.056 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site