Messages in this thread | | | Date | Fri, 2 Aug 2013 05:50:19 +0800 | From | Greg KH <> | Subject | Re: [PATCH] Staging: wlags49_h2: fixed 80 line character and white space issue in ap_h2.c Fixed various coding style warnings found by the checkpatch.pl tool |
| |
On Wed, Jul 31, 2013 at 01:44:25PM -0700, Evan Ng wrote: > From: esn89 <evan.sin.ng@gmail.com>
I need a real name here, odds are "esn89" isn't yours :)
Also, look at the subject you created, it's not correct, you need to add a newline after a short description, followed by the longer description, for git to pick this up properly.
> Signed-off-by: Evan Ng <evan.sin.ng@gmail.com> > --- > drivers/staging/wlags49_h2/ap_h2.c | 7884 +++++++++++++++++++++--------------- > 1 file changed, 4668 insertions(+), 3216 deletions(-)
That's almos impossible to review, can you do "one thing at a time" so that we can review it? Break it up into lots of different pieces and send a series of patches.
thanks,
greg k-h
| |