lkml.org 
[lkml]   [2013]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH 10/17] perf ftrace: Add dump_printf() for low-level debugging
Date
From: Namhyung Kim <namhyung.kim@lge.com>

For reusability, rename trace_event() to dump_raw_event() and pass
size as an argument. And use it in do_ftrace_report() to show raw
data of ftrace entries.

Signed-off-by: Namhyung Kim <namhyung@kernel.org>
---
tools/perf/builtin-ftrace.c | 6 ++++++
tools/perf/util/debug.c | 8 ++++----
tools/perf/util/debug.h | 2 +-
tools/perf/util/session.c | 2 +-
4 files changed, 12 insertions(+), 6 deletions(-)

diff --git a/tools/perf/builtin-ftrace.c b/tools/perf/builtin-ftrace.c
index 0792bfdf168c..bb0a238b8509 100644
--- a/tools/perf/builtin-ftrace.c
+++ b/tools/perf/builtin-ftrace.c
@@ -1330,6 +1330,12 @@ static int do_ftrace_report(struct perf_ftrace *ftrace)
goto out;
}

+ dump_printf(" .... event: %s\n", perf_evsel__name(evsel));
+ dump_raw_event(record, record->size);
+ dump_printf("%3d %llu %#llx [%#x]\n\n",
+ record->cpu, record->ts, record->offset,
+ record->size);
+
/* TODO: update sample.period using calltime */
if (!__hists__add_entry(&evsel->hists, &al, NULL,
sample.period, 0)) {
diff --git a/tools/perf/util/debug.c b/tools/perf/util/debug.c
index 399e74c34c1a..2c42aaed4528 100644
--- a/tools/perf/util/debug.c
+++ b/tools/perf/util/debug.c
@@ -47,7 +47,7 @@ int dump_printf(const char *fmt, ...)
return ret;
}

-void trace_event(union perf_event *event)
+void dump_raw_event(void *event, int size)
{
unsigned char *raw_event = (void *)event;
const char *color = PERF_COLOR_BLUE;
@@ -58,9 +58,9 @@ void trace_event(union perf_event *event)

printf(".");
color_fprintf(stdout, color, "\n. ... raw event: size %d bytes\n",
- event->header.size);
+ size);

- for (i = 0; i < event->header.size; i++) {
+ for (i = 0; i < size; i++) {
if ((i & 15) == 0) {
printf(".");
color_fprintf(stdout, color, " %04x: ", i);
@@ -68,7 +68,7 @@ void trace_event(union perf_event *event)

color_fprintf(stdout, color, " %02x", raw_event[i]);

- if (((i & 15) == 15) || i == event->header.size-1) {
+ if (((i & 15) == 15) || i == size-1) {
color_fprintf(stdout, color, " ");
for (j = 0; j < 15-(i & 15); j++)
color_fprintf(stdout, color, " ");
diff --git a/tools/perf/util/debug.h b/tools/perf/util/debug.h
index efbd98805ad0..9cebb0cdb7bd 100644
--- a/tools/perf/util/debug.h
+++ b/tools/perf/util/debug.h
@@ -12,7 +12,7 @@ extern int verbose;
extern bool quiet, dump_trace;

int dump_printf(const char *fmt, ...) __attribute__((format(printf, 1, 2)));
-void trace_event(union perf_event *event);
+void dump_raw_event(void *event, int size);

int ui__error(const char *format, ...) __attribute__((format(printf, 1, 2)));
int ui__warning(const char *format, ...) __attribute__((format(printf, 1, 2)));
diff --git a/tools/perf/util/session.c b/tools/perf/util/session.c
index a0ce5a46abbe..8e6d05acab32 100644
--- a/tools/perf/util/session.c
+++ b/tools/perf/util/session.c
@@ -793,7 +793,7 @@ static void dump_event(struct perf_session *session, union perf_event *event,
printf("\n%#" PRIx64 " [%#x]: event: %d\n",
file_offset, event->header.size, event->header.type);

- trace_event(event);
+ dump_raw_event(event, event->header.size);

if (sample)
perf_session__print_tstamp(session, event, sample);
--
1.7.11.7


\
 
 \ /
  Last update: 2013-07-30 11:41    [W:0.217 / U:2.268 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site