lkml.org 
[lkml]   [2013]   [Jul]   [30]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 01/17] perf util: Save pid-cmdline mapping into tracing header
Hi Arnaldo,

2013-07-30 오후 10:28, Arnaldo Carvalho de Melo 쓴 글:
> Em Tue, Jul 30, 2013 at 06:18:58PM +0900, Namhyung Kim escreveu:
>> From: Namhyung Kim <namhyung.kim@lge.com>
>>
>> Current trace info data lacks the saved cmdline mapping which is
>> needed for pevent to find out the comm of a task. Add this and bump
>> up the version number so that perf can determine its presence when
>> reading.
>
> Can't we get this from the PERF_RECORD_COMM synthesized at the beginning
> of the session + the kernel generated ones for new threads?
>
> We would just call machine__find_thread() and use thread->comm, etc, no?

Yes, I think it's doable. However it needs an additional perf event
only to generate the COMM events. So I decided not to do it and reused
saved cmdline info from ftrace. But IIUC it also has a problem of
possible information loss due to the size of table.

Thanks,
Namhyung

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2013-07-31 03:21    [W:0.059 / U:2.172 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site