Messages in this thread Patch in this message | | | From | Andi Shyti <> | Subject | [PATCH] btrfs: raid56: avoid double allocation | Date | Thu, 25 Jul 2013 02:09:40 +0200 |
| |
alloc_rbio frees already bbio and raid_map, therefore they don't need to be freed in case it fails
Signed-off-by: Andi Shyti <andi@etezian.org> --- fs/btrfs/raid56.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/fs/btrfs/raid56.c b/fs/btrfs/raid56.c index 0525e13..35fe775 100644 --- a/fs/btrfs/raid56.c +++ b/fs/btrfs/raid56.c @@ -1687,11 +1687,9 @@ int raid56_parity_write(struct btrfs_root *root, struct bio *bio, struct blk_plug_cb *cb; rbio = alloc_rbio(root, bbio, raid_map, stripe_len); - if (IS_ERR(rbio)) { - kfree(raid_map); - kfree(bbio); + if (IS_ERR(rbio)) return PTR_ERR(rbio); - } + bio_list_add(&rbio->bio_list, bio); rbio->bio_list_bytes = bio->bi_size; -- 1.8.3.2
| |