Messages in this thread | | | Date | Mon, 22 Jul 2013 16:35:25 +0200 (CEST) | From | Jiri Kosina <> | Subject | Re: [PATCH 1/2] Revert "Revert "HID: Fix logitech-dj: missing Unifying device issue"" |
| |
On Thu, 18 Jul 2013, Nestor Lopez Casado wrote:
> This reverts commit 8af6c08830b1ae114d1a8b548b1f8b056e068887. > > This patch re-adds the workaround introduced by 596264082f10dd4 > which was reverted by 8af6c08830b1ae114. > > The original patch 596264 was needed to overcome a situation where > the hid-core would drop incoming reports while probe() was being > executed. > > This issue was solved by c849a6143bec520af which added > hid_device_io_start() and hid_device_io_stop() that enable a specific > hid driver to opt-in for input reports while its probe() is being > executed. > > Commit a9dd22b730857347 modified hid-logitech-dj so as to use the > functionality added to hid-core. Having done that, workaround 596264 > was no longer necessary and was reverted by 8af6c08. > > We now encounter a different problem that ends up 'again' thwarting > the Unifying receiver enumeration. The problem is time and usb controller > dependent. Ocasionally the reports sent to the usb receiver to start > the paired devices enumeration fail with -EPIPE and the receiver never > gets to enumerate the paired devices. [ ... snip ... ]
Ok, this is now in
git://git.kernel.org/pub/scm/linux/kernel/git/jikos/hid.git for-3.11/logitech-enumeration-fix
Linus added to CC.
Linus -- could you please by any chance test whether the two patches in that branch make the problem you are observing any better? (and no, this is not a pull request yet).
It's still not clear whether we are chasing two different issues here, or not.
Thanks,
-- Jiri Kosina SUSE Labs
| |