Messages in this thread | | | Date | Wed, 17 Jul 2013 18:22:37 -0700 (PDT) | Subject | Re: [PATCH] net/sun3_82586: Kill array subscript above array bounds warning | From | David Miller <> |
| |
From: Geert Uytterhoeven <geert@linux-m68k.org> Date: Wed, 17 Jul 2013 14:25:05 +0200
> drivers/net/ethernet/i825xx/sun3_82586.c: In function 'sun3_82586_timeout': > drivers/net/ethernet/i825xx/sun3_82586.c:993:89: warning: array subscript is above array bounds [-Warray-bounds] > > Using the default NUM_XMIT_BUFFS = 1, there's only one transmit buffer. > Hence accessing the second buffer is an out-of-bounds access. > Print the command status of the first NOP buffer instead. > > Fortunately this actually worked fine, as the layout of transmit and NOP > buffers is sufficiently similar. > > Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
Three more CPP directives in a DEBUG ifdef'd piece of code, yuck.
I'd say just kill this whole DEBUG section entirely. If people want this driver to print this debugging, do it properly with netif_err() or similar.
| |