Messages in this thread Patch in this message | | | Date | Mon, 01 Jul 2013 19:34:53 -0700 (PDT) | From | Kuninori Morimoto <> | Subject | [PATCH] shdma: fixup sh_dmae_get_partial() calculation error |
| |
sh_desc->hw.tcr is controlling data size, and register TCR is controlling data transfer count which was xmit_shift'ed value of hw.tcr. Current sh_dmae_get_partial() is calculating in different unit. This patch fixes it.
Cc: Guennadi Liakhovetski <g.liakhovetski@gmx.de> Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com> --- >> Guennadi
Can you please review this patch ?
drivers/dma/sh/shdma.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/dma/sh/shdma.c b/drivers/dma/sh/shdma.c index b70709b..d670b8b 100644 --- a/drivers/dma/sh/shdma.c +++ b/drivers/dma/sh/shdma.c @@ -388,8 +388,8 @@ static size_t sh_dmae_get_partial(struct shdma_chan *schan, shdma_chan); struct sh_dmae_desc *sh_desc = container_of(sdesc, struct sh_dmae_desc, shdma_desc); - return (sh_desc->hw.tcr - sh_dmae_readl(sh_chan, TCR)) << - sh_chan->xmit_shift; + return sh_desc->hw.tcr - + (sh_dmae_readl(sh_chan, TCR) << sh_chan->xmit_shift); } /* Called from error IRQ or NMI */ -- 1.7.9.5
| |