Messages in this thread | | | Date | Sun, 9 Jun 2013 22:21:27 +0300 | Subject | Re: [PATCH] dmatest: add ability to disable pq and xor | From | Andy Shevchenko <> |
| |
On Tue, Jun 4, 2013 at 8:11 PM, Dan Williams <djbw@fb.com> wrote: > On 6/4/13 12:25 AM, "Andy Shevchenko" <andy.shevchenko@gmail.com> wrote: >>On Tue, Jun 4, 2013 at 2:29 AM, Jon Mason <jon.mason@intel.com> wrote: >>> On Fri, May 31, 2013 at 11:22:10AM +0300, Andy Shevchenko wrote:
[]
>>> Since the testing is started immediately upon module >>> insertion, >>It used to be so, but nowadays it's true only when dmatest is compiled in. >>If someone wants to compile in that module they probably want to run >>stress tests, where XOR and PQ might be useful. > > ...and they would want the test selection to be specified on the kernel > command line. At least that's how I used compiled in dmatest in the past.
Actually you're right. Better to have it in that case too.
>>My opinion I already shared, new node under debugfs. There is might be >>a good reason to add a new module parameter as well. > > I'm not seeing why debugfs is helpful here. Just make it a module > parameter that calls a routine to setup the bit mask.
I'm not objecting against module parameter, though I would like to see debugfs node for that as well.
-- With Best Regards, Andy Shevchenko
| |