Messages in this thread | | | Date | Thu, 06 Jun 2013 07:14:08 -0500 | From | Mark Langsdorf <> | Subject | Re: [PATCH 2/2] sata highbank: add bit-banged SGPIO driver support |
| |
,On 06/05/2013 06:15 PM, Tejun Heo wrote: > Hello, > > On Wed, Jun 05, 2013 at 05:31:48PM -0500, Mark Langsdorf wrote: >> +static void ecx_parse_sgpio(struct ecx_plat_data *pdata, u32 port, u32 state) >> +{ >> + if (state & ECX_ACTIVITY_BITS) >> + pdata->sgpio_pattern |= sgpio_bit_shift(pdata, port, >> + ECX_ACTIVITY_SHIFT); >> + else >> + pdata->sgpio_pattern &= sgpio_bit_shift(pdata, port, >> + ECX_ACTIVITY_SHIFT); > > Shouldn't it be "&= ~" instead of "&="? You're trying to turn the bit > off, right?
Oops. Thanks!
--Mark Langsdorf Calxeda, Inc.
| |