Messages in this thread | | | Date | Wed, 5 Jun 2013 16:15:17 -0700 | From | Tejun Heo <> | Subject | Re: [PATCH 2/2] sata highbank: add bit-banged SGPIO driver support |
| |
Hello,
On Wed, Jun 05, 2013 at 05:31:48PM -0500, Mark Langsdorf wrote: > +static void ecx_parse_sgpio(struct ecx_plat_data *pdata, u32 port, u32 state) > +{ > + if (state & ECX_ACTIVITY_BITS) > + pdata->sgpio_pattern |= sgpio_bit_shift(pdata, port, > + ECX_ACTIVITY_SHIFT); > + else > + pdata->sgpio_pattern &= sgpio_bit_shift(pdata, port, > + ECX_ACTIVITY_SHIFT);
Shouldn't it be "&= ~" instead of "&="? You're trying to turn the bit off, right?
Looks okay to me otherwise.
Thanks.
-- tejun
| |