Messages in this thread | | | Date | Tue, 4 Jun 2013 08:01:13 -0500 | Subject | Re: [PATCH 15/15] OF: remove #ifdef from linux/of_platform.h | From | Rob Herring <> |
| |
On Sat, Jun 1, 2013 at 3:57 PM, Arnd Bergmann <arnd@arndb.de> wrote: > On Saturday 01 June 2013, Rob Herring wrote: >> No, we still need empty functions. Here is what of_device.h looks like: >> >> http://tinyurl.com/l2azz5m >> >> BTW, it has your ack. >> > > Could you add a patch on top that only puts the function declarations > inside of #ifdef that don't have an inline wrapper?
I'm confused. You mean that DO have an inline? Like this:
void foo(void);
#ifdef CONFIG_OF void bar(void); #else static inline void bar(void) {} #endif
> It's really annoying to have to change the header file every time one > needs to call a function from a driver in the DT-only case.
The functions without inlines are ones that drivers should not call and should only be called from OF enabled code. That's why we have not done a complete pass of adding inlines for everything.
Rob
| |