Messages in this thread | | | Subject | Re: [PATCH V2 2/8] pktcdvd: Convert printk to pr_<level> | From | Joe Perches <> | Date | Mon, 03 Jun 2013 04:59:31 -0700 |
| |
On Mon, 2013-06-03 at 12:57 +0300, Dan Carpenter wrote: > On Fri, May 31, 2013 at 09:11:23PM -0700, Joe Perches wrote: > > +static const char *sense_key_string(__u8 index) > > +{ > > + static const char *info[9] = { > > + "No sense", "Recovered error", "Not ready", > > + "Medium error", "Hardware error", "Illegal request", > > + "Unit attention", "Data protect", "Blank check" > > + }; > > + if (index < 8) > > Off by one: > > if (index < 9)
Kinda, but that's the original code.
It should be ARRAY_SIZE and I think it should be done in a separate patch.
Someone should say if "Blank check" is really one of the sense key values possible or if it should just be deleted.
| |