lkml.org 
[lkml]   [2013]   [Jun]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH V2 6/8] pktcdvd: Convert pr_notice to pkt_notice
From
On Sat, Jun 1, 2013 at 7:11 AM, Joe Perches <joe@perches.com> wrote:
> Add a new pkt_notice macro to prefix the name to the logging output.

One nitpick below.

> --- a/drivers/block/pktcdvd.c
> +++ b/drivers/block/pktcdvd.c
> @@ -71,17 +71,19 @@
>
> #define DRIVER_NAME "pktcdvd"
>
> +#define pkt_err(pd, fmt, ...) \
> + pr_err("%s: " fmt, pd->name, ##__VA_ARGS__)
> +#define pkt_notice(pd, fmt, ...) \
> + pr_notice("%s: " fmt, pd->name, ##__VA_ARGS__)
> +
> #define pkt_dbg(level, pd, fmt, ...) \
> do { \
> if (level == 2 && PACKET_DEBUG >= 2) \
> - pr_notice("%s: %s():" fmt, \
> - pd->name, __func__, ##__VA_ARGS__); \
> + pkt_notice(pd, "%s(): " fmt, __func__, ##__VA_ARGS__); \
> else if (level == 1 && PACKET_DEBUG >= 1) \
> - pr_notice("%s: " fmt, pd->name, ##__VA_ARGS__); \
> + pkt_notice(pd, fmt, ##__VA_ARGS__); \
> } while (0)
>
> -#define pkt_err(pd, fmt, ...) \
> - pr_err("%s: " fmt, pd->name, ##__VA_ARGS__)

May be put this in the right place before?

--
With Best Regards,
Andy Shevchenko


\
 
 \ /
  Last update: 2013-06-02 14:21    [W:0.509 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site