Messages in this thread | | | Date | Sat, 29 Jun 2013 09:05:29 +0200 | From | Maxime Ripard <> | Subject | Re: [PATCHv3 5/8] ARM: mxs: dt: cfa10037: make hogpins grabbed by respective drivers |
| |
Hi Alexandre
On Fri, Jun 28, 2013 at 03:02:54PM +0200, Alexandre Belloni wrote: > Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Acked-by: Maxime Ripard <maxime.ripard@free-electrons.com> With one minor comment, that applies to your other patches as well.
> --- > arch/arm/boot/dts/imx28-cfa10037.dts | 19 ++++++++++++++----- > 1 file changed, 14 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/dts/imx28-cfa10037.dts b/arch/arm/boot/dts/imx28-cfa10037.dts > index c2ef3a3..182b99f 100644 > --- a/arch/arm/boot/dts/imx28-cfa10037.dts > +++ b/arch/arm/boot/dts/imx28-cfa10037.dts > @@ -22,13 +22,19 @@ > apb@80000000 { > apbh@80000000 { > pinctrl@80018000 { > - pinctrl-names = "default", "default"; > - pinctrl-1 = <&hog_pins_cfa10037>;
The pinctrl-name property isn't relevant since the 10036 patch. You should probably have ordered them the other way around: first the breakout board, then the 10036.
Maxime
-- Maxime Ripard, Free Electrons Embedded Linux, Kernel and Android engineering http://free-electrons.com [unhandled content-type:application/pgp-signature] | |