Messages in this thread | | | Date | Sat, 29 Jun 2013 00:44:18 +0200 | From | Michal Marek <> | Subject | Re: [PATCH] let kbuild mkdir for dir/file.o |
| |
Hi,
sorry for the late feedback.
Dne 4.6.2013 10:45, 张忠山 napsal(a): > when add a obj with dir to obj-y, like this > > obj-y += dir/file.o > > the $(obj)/dir not created, this patch fix this > > this bug caused by commit > f5fb976520a53f45f8bbf2e851f16b3b5558d485
Please also include the wonderful explanation including the error message that you posted separately (http://permalink.gmane.org/gmane.linux.kbuild.devel/10050). Also, please CC linux-kernel in addition to linux-kbuild.
> > Signed-off-by: 张忠山 <zzs0213@gmail.com> > --- > scripts/Makefile.lib | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/scripts/Makefile.lib b/scripts/Makefile.lib > index 51bb3de..6bae5a9 100644 > --- a/scripts/Makefile.lib > +++ b/scripts/Makefile.lib > @@ -63,7 +63,8 @@ multi-objs := $(multi-objs-y) $(multi-objs-m) > subdir-obj-y := $(filter %/built-in.o, $(obj-y)) > > # $(obj-dirs) is a list of directories that contain object files > -obj-dirs := $(dir $(multi-objs) $(subdir-obj-y)) > +__subdir-obj-y := $(foreach o,$(obj-y),$(if $(filter-out $(o),$(notdir $(o))),$(o)))
This complicated filter returns entries from $(obj-y) that contain a slash, is that correct? If so, is it really necessary? Why not simply add whole $(obj-y) to $(obj-dirs) and be done? $(multi-objs) is also added without any filtering.
> +obj-dirs := $(dir $(multi-objs) $(__subdir-obj-y))
thanks, Michal -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |