Messages in this thread | | | Date | Fri, 28 Jun 2013 11:36:51 +0100 | From | Srinivas KANDAGATLA <> | Subject | Re: [PATCH] pinctrl: st: Fix checking return value of syscon_regmap_lookup_by_phandle() |
| |
Thankyou Axel for looking at this.
There is already a patch is submitted for this. https://lkml.org/lkml/2013/6/26/494 which I have Acked.
Thanks, srini On 28/06/13 11:33, Axel Lin wrote: > syscon_regmap_lookup_by_phandle() returns ERR_PTR on error. > > Signed-off-by: Axel Lin <axel.lin@ingics.com> > --- > drivers/pinctrl/pinctrl-st.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c > index 7effedf..f95c82a 100644 > --- a/drivers/pinctrl/pinctrl-st.c > +++ b/drivers/pinctrl/pinctrl-st.c > @@ -1299,9 +1299,9 @@ static int st_pctl_probe_dt(struct platform_device *pdev, > return -ENOMEM; > > info->regmap = syscon_regmap_lookup_by_phandle(np, "st,syscfg"); > - if (!info->regmap) { > + if (IS_ERR(info->regmap)) { > dev_err(info->dev, "No syscfg phandle specified\n"); > - return -ENOMEM; > + return PTR_ERR(info->regmap); > } > info->data = of_match_node(st_pctl_of_match, np)->data; > >
| |