lkml.org 
[lkml]   [2013]   [Jun]   [28]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] pinctrl: st: Fix checking return value of syscon_regmap_lookup_by_phandle()
From
2013/6/28 Srinivas KANDAGATLA <srinivas.kandagatla@st.com>:
> On 28/06/13 13:16, Axel Lin wrote:
>> 2013/6/28 Srinivas KANDAGATLA <srinivas.kandagatla@st.com>:
>>> Thankyou Axel for looking at this.
>>>
>>> There is already a patch is submitted for this.
>>> https://lkml.org/lkml/2013/6/26/494 which I have Acked.
>>
>> That is strange.
>> I don't think the patch you mentioned can be applied to current pinctrl tree.
>> Current code does check pinctrl_register by IS_ERR.
> The patch removes the IS_ERR, because, pinctrl_register returns NULL or
> a valid pointer, using IS_ERR is this case is incorrect.
You are right.

Thanks,
Axel


\
 
 \ /
  Last update: 2013-06-28 17:01    [W:0.032 / U:2.584 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site