Messages in this thread | | | Date | Fri, 28 Jun 2013 22:24:24 +0800 | Subject | Re: [PATCH] pinctrl: st: Fix checking return value of syscon_regmap_lookup_by_phandle() | From | Axel Lin <> |
| |
2013/6/28 Srinivas KANDAGATLA <srinivas.kandagatla@st.com>: > On 28/06/13 13:16, Axel Lin wrote: >> 2013/6/28 Srinivas KANDAGATLA <srinivas.kandagatla@st.com>: >>> Thankyou Axel for looking at this. >>> >>> There is already a patch is submitted for this. >>> https://lkml.org/lkml/2013/6/26/494 which I have Acked. >> >> That is strange. >> I don't think the patch you mentioned can be applied to current pinctrl tree. >> Current code does check pinctrl_register by IS_ERR. > The patch removes the IS_ERR, because, pinctrl_register returns NULL or > a valid pointer, using IS_ERR is this case is incorrect. You are right.
Thanks, Axel
| |