lkml.org 
[lkml]   [2013]   [Jun]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 06/19] perf ftrace: Add support for --pid option
On 6/26/13 1:14 AM, Namhyung Kim wrote:
> @@ -196,6 +222,8 @@ int cmd_ftrace(int argc, const char **argv, const char *prefix __maybe_unused)
> const struct option ftrace_options[] = {
> OPT_STRING('t', "tracer", &ftrace.tracer, "tracer",
> "tracer to use"),
> + OPT_STRING('p', "pid", &ftrace.target.tid, "pid",
> + "trace on existing process id"),
> OPT_INCR('v', "verbose", &verbose,
> "be more verbose"),
> OPT_END()

You are calling it pid but assigning it as a tid which is inconsistent
with other perf commands. e.g., perf-record allows a list of pids (-p)
or tids (-t). Why not support that in perf-ftrace? And that leads to the
comment about consistency of options across perf commands: -t is used
here for tracer type to use.

David



\
 
 \ /
  Last update: 2013-06-26 23:21    [W:0.300 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site