Messages in this thread | | | From | Namhyung Kim <> | Subject | Re: [PATCH 11/19] perf ftrace: Add 'report' sub-command | Date | Thu, 11 Jul 2013 17:10:12 +0900 |
| |
On Wed, 10 Jul 2013 16:45:39 +0200, Jiri Olsa wrote: > On Wed, Jun 26, 2013 at 04:14:14PM +0900, Namhyung Kim wrote: > > SNIP > >> >> +static int >> +__cmd_ftrace_report(struct perf_ftrace *ftrace, int argc, const char **argv) >> +{ >> + int ret = -1; >> + const char * const report_usage[] = { >> + "perf ftrace report [<options>]", >> + NULL >> + }; >> + const struct option report_options[] = { >> + OPT_STRING('i', "input", &ftrace->dirname, "dirname", >> + "input directory name to use (default: perf.data)"), >> + OPT_INCR('v', "verbose", &verbose, >> + "be more verbose"), >> + OPT_BOOLEAN('D', "dump-raw-trace", &dump_trace, >> + "dump raw trace in ASCII"), > > not sure dump_trace is useful here, it's just the first cpu-x samples > and then following 2 lines repeated MANY times: > > ... thread: ls:30064 > ...... dso: [kernel.kallsyms] > > I guess you need this to verify first SAMPLEs?
I can't remember why exactly. ;-)
Probably I was thinking about adding more info like raw ftrace data.
Thanks, Namhyung
| |