Messages in this thread | | | From | Bjorn Helgaas <> | Date | Tue, 25 Jun 2013 15:46:49 -0600 | Subject | Re: [PATCH v5 3/7] PCI: Use pci_walk_bus to detect unassigned resources |
| |
On Tue, Jun 25, 2013 at 3:38 PM, Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote: > On Tue, 2013-06-25 at 15:15 -0600, Bjorn Helgaas wrote: >> - for_each_pci_dev(dev) { >> > - int i; >> > + /* Not assigned, or rejected by kernel ? */ >> > + if (r->flags && !r->start) { >> > + (*unassigned)++; >> > + return 1; /* return early from pci_walk_bus */ >> > + } >> > + } > > BTW. I'm aware you didn't change that logic but ... it's somewhat broken > in the case where the aperture has an offset. You should compare > r->start with the offset, not with 0.
Yes, please fix that in a separate patch that contains only the bugfix.
| |