lkml.org 
[lkml]   [2013]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
Date
SubjectRe: [PATCH v5 3/7] PCI: Use pci_walk_bus to detect unassigned resources
On Tue, Jun 25, 2013 at 3:38 PM, Benjamin Herrenschmidt
<benh@kernel.crashing.org> wrote:
> On Tue, 2013-06-25 at 15:15 -0600, Bjorn Helgaas wrote:
>> - for_each_pci_dev(dev) {
>> > - int i;
>> > + /* Not assigned, or rejected by kernel ? */
>> > + if (r->flags && !r->start) {
>> > + (*unassigned)++;
>> > + return 1; /* return early from pci_walk_bus */
>> > + }
>> > + }
>
> BTW. I'm aware you didn't change that logic but ... it's somewhat broken
> in the case where the aperture has an offset. You should compare
> r->start with the offset, not with 0.

Yes, please fix that in a separate patch that contains only the bugfix.


\
 
 \ /
  Last update: 2013-06-26 05:01    [W:0.056 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site