lkml.org 
[lkml]   [2013]   [Jun]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH v5 3/7] PCI: Use pci_walk_bus to detect unassigned resources
From
Date
On Tue, 2013-06-25 at 15:15 -0600, Bjorn Helgaas wrote:
> - for_each_pci_dev(dev) {
> > - int i;
> > + /* Not assigned, or rejected by kernel ? */
> > + if (r->flags && !r->start) {
> > + (*unassigned)++;
> > + return 1; /* return early from pci_walk_bus */
> > + }
> > + }

BTW. I'm aware you didn't change that logic but ... it's somewhat broken
in the case where the aperture has an offset. You should compare
r->start with the offset, not with 0.

Cheers,
Ben.




\
 
 \ /
  Last update: 2013-06-26 00:21    [W:0.042 / U:2.528 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site