Messages in this thread | | | Date | Sun, 16 Jun 2013 10:36:33 +0200 | Subject | Re: Linux 3.10-rc6 | From | Geert Uytterhoeven <> |
| |
On Sun, Jun 16, 2013 at 12:12 AM, Linus Torvalds <torvalds@linux-foundation.org> wrote: > David Daney (3): > smp.h: Use local_irq_{save,restore}() in !SMP version of on_each_cpu().
This change (commit f21afc25f9ed45b8ffe200d0f071b0caec3ed2ef, which hasn't been in linux-next), broke at least mn10300 and ia64:
include/linux/smp.h:148:2: error: implicit declaration of function 'local_irq_save' [-Werror=implicit-function-declaration] include/linux/smp.h:150:2: error: implicit declaration of function 'local_irq_restore' [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors make[2]: *** [arch/mn10300/kernel/asm-offsets.s] Error 1 http://kisskb.ellerman.id.au/kisskb/buildresult/8968250/
arch/mn10300/include/asm/irqflags.h:71:2: error: implicit declaration of function 'raw_smp_processor_id' [-Werror=implicit-function-declaration] arch/mn10300/include/asm/irqflags.h:71:2: error: implicit declaration of function 'raw_smp_processor_id' [-Werror=implicit-function-declaration] cc1: some warnings being treated as errors make[2]: *** [arch/mn10300/kernel/smp.o] Error 1 http://kisskb.ellerman.id.au/kisskb/buildresult/8968248/
arch/ia64/include/asm/irqflags.h:49:1: error: 'IA64_PSR_I' undeclared (first use in this function) arch/ia64/include/asm/irqflags.h:60:1: error: 'IA64_PSR_I' undeclared (first use in this function) arch/ia64/include/asm/irqflags.h:67:1: error: 'IA64_PSR_I' undeclared (first use in this function) arch/ia64/include/asm/irqflags.h:76:1: error: 'IA64_PSR_I' undeclared (first use in this function) arch/ia64/include/asm/irqflags.h:82:18: error: 'IA64_PSR_I' undeclared (first use in this function) arch/ia64/include/asm/irqflags.h:49:1: error: 'IA64_PSR_I' undeclared (first use in this function) arch/ia64/include/asm/irqflags.h:60:1: error: 'IA64_PSR_I' undeclared (first use in this function) arch/ia64/include/asm/irqflags.h:67:1: error: 'IA64_PSR_I' undeclared (first use in this function) arch/ia64/include/asm/irqflags.h:76:1: error: 'IA64_PSR_I' undeclared (first use in this function) arch/ia64/include/asm/irqflags.h:82:18: error: 'IA64_PSR_I' undeclared (first use in this function) arch/ia64/include/asm/irqflags.h:49:1: error: 'IA64_PSR_I' undeclared (first use in this function) arch/ia64/include/asm/irqflags.h:60:1: error: 'IA64_PSR_I' undeclared (first use in this function) arch/ia64/include/asm/irqflags.h:67:1: error: 'IA64_PSR_I' undeclared (first use in this function) arch/ia64/include/asm/irqflags.h:76:1: error: 'IA64_PSR_I' undeclared (first use in this function) arch/ia64/include/asm/irqflags.h:82:18: error: 'IA64_PSR_I' undeclared (first use in this function) make[2]: *** [kernel/softirq.o] Error 1 http://kisskb.ellerman.id.au/kisskb/buildresult/8968433/
Reverting it seems to fix the failures (complete build still in progress).
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |