Messages in this thread | | | Date | Fri, 14 Jun 2013 15:09:49 -0300 | From | Emilio López <> | Subject | Re: [linux-sunxi] [PATCH 5/6] ARM: sunxi: Add Olimex A10s-Olinuxino-micro device tree |
| |
Hi Maxime,
El 09/06/13 13:36, Maxime Ripard escribió: > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > --- > arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts | 75 ++++++++++++++++++++++++ > 1 file changed, 75 insertions(+) > create mode 100644 arch/arm/boot/dts/sun5i-a10s-olinuxino-micro.dts
Please add this on the sunxi target in arch/arm/boot/dts/Makefile so it gets built on make dtbs.
(snip)
> + leds { > + compatible = "gpio-leds"; > + pinctrl-names = "default"; > + pinctrl-0 = <&led_pins_olinuxino>; > + > + power { > + gpios = <&pio 4 3 0>; > + default-state = "on"; > + };
Also, as discussed on IRC, I think it would be wise to change the name on the LED node. The schematics have a 'power' led already that is hard-wired to 3.3v, and this led node that you are declaring is referred as 'led1' there. I suppose 'green' would be a suitable name to keep consistency with other sunxi boards (namely cubieboard).
Other than that, my OLinuXino worked just fine after applying this patchset, so
Tested-by: Emilio López <emilio@elopez.com.ar>
Thanks!
Emilio -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |