Messages in this thread Patch in this message | | | Date | Thu, 13 Jun 2013 14:21:51 +0800 | From | "zhangwei(Jovi)" <> | Subject | [PATCH] uprobes: fix return value in error handling path |
| |
When I inject incorrect argument into uprobe_events,
[root@jovi tracing]# echo 'p:myprobe /bin/bash' > uprobe_events [root@jovi tracing]#
it doesn't return any error value in there, this patch fix it.
Signed-off-by: zhangwei(Jovi) <jovi.zhangwei@huawei.com> --- kernel/trace/trace_uprobe.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/kernel/trace/trace_uprobe.c b/kernel/trace/trace_uprobe.c index 32494fb0..d5d0cd3 100644 --- a/kernel/trace/trace_uprobe.c +++ b/kernel/trace/trace_uprobe.c @@ -283,8 +283,10 @@ static int create_trace_uprobe(int argc, char **argv) return -EINVAL; } arg = strchr(argv[1], ':'); - if (!arg) + if (!arg) { + ret = -EINVAL; goto fail_address_parse; + }
*arg++ = '\0'; filename = argv[1]; -- 1.7.9.7
| |