Messages in this thread | | | Date | Sun, 9 Jun 2013 22:51:15 -0700 (PDT) | From | PINTU KUMAR <> | Subject | [checkpatch] - Confusion |
| |
Hi,
I wanted to submit my first patch. But I have some confusion about the /scripts/checkpatch.pl errors.
After correcting some checkpatch errors, when I run checkpatch.pl, it showed me 0 errors. But when I create patches are git format-patch, it is showing me 1 error.
If I fix error in patch, it showed me back again in files.
Now, I am confused which error to fix while submitting patches, the file or the patch errors.
Please provide your opinion.
File: mm/page_alloc.c Previous file errors: total: 16 errors, 110 warnings, 6255 lines checked
After fixing errors: total: 0 errors, 105 warnings, 6255 lines checked
And, after running on patch: ERROR: need consistent spacing around '*' (ctx:WxV) #153: FILE: mm/page_alloc.c:5476: +int min_free_kbytes_sysctl_handler(ctl_table *table, int write,
- Pintu
| |