Messages in this thread | | | Subject | Re: [RFC][PATCH 7/7] drain batch list during long operations | From | Tim Chen <> | Date | Tue, 07 May 2013 17:42:02 -0700 |
| |
On Tue, 2013-05-07 at 14:20 -0700, Dave Hansen wrote: > From: Dave Hansen <dave.hansen@linux.intel.com> > > This was a suggestion from Mel: > > http://lkml.kernel.org/r/20120914085634.GM11157@csn.ul.ie > > Any pages we collect on 'batch_for_mapping_removal' will have > their lock_page() held during the duration of their stay on the > list. If some other user is trying to get at them during this > time, they might end up having to wait for a while, especially if > we go off and do pageout() on some other page. > > This ensures that we drain the batch if we are about to perform a > writeout. > > I added some statistics to the __remove_mapping_batch() code to > track how large the lists are that we pass in to it. With this > patch, the average list length drops about 10% (from about 4.1 to > 3.8). The workload here was a make -j4 kernel compile on a VM > with 200MB of RAM. > > I've still got the statistics patch around if anyone is > interested. > > Signed-off-by: Dave Hansen <dave.hansen@linux.intel.com>
I like this new patch series. Logic is cleaner than my previous attempt.
Acked.
Tim
| |