lkml.org 
[lkml]   [2013]   [May]   [14]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC][PATCH 6/7] use __remove_mapping_batch() in shrink_page_list()
On 05/14/2013 09:05 AM, Mel Gorman wrote:
> This helper seems overkill. Why not just have batch_mapping in
> shrink_page_list() that is set when the first page is added to the
> batch_for_mapping_removal and defer the decision to drain until after the
> page mapping has been looked up?
>
> struct address_space *batch_mapping = NULL;
>
> .....
>
> mapping = page_mapping(page);
> if (!batch_mapping)
> batch_mapping = mapping;
>
> if (!list_empty(&batch_for_mapping_removal) && mapping != batch_mapping) {
> nr_reclaimed += __remove_mapping_batch(....);
> batch_mapping = mapping;
> }

I was trying to avoid doing the batch drain while holding lock_page() on
an unrelated page. But, now that I think about it, that was probably
unsafe anyway. The page could have been truncated out of the mapping
since it *was* before lock_page().

I think I was also trying to save adding another local variable, but
you're right that it's overkill. I'll fix it up.


\
 
 \ /
  Last update: 2013-05-14 21:21    [W:0.064 / U:0.536 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site