Messages in this thread | | | Date | Mon, 06 May 2013 16:49:22 +0800 | From | Alex Shi <> | Subject | Re: [PATCH v5 1/7] Revert "sched: Introduce temporary FAIR_GROUP_SCHED dependency for load-tracking" |
| |
On 05/06/2013 04:24 PM, Paul Turner wrote: >> > /* >> > * CFS Load tracking >> > * Under CFS, load is tracked on a per-entity basis and aggregated up. >> > @@ -242,8 +236,7 @@ struct cfs_rq { >> > u64 runnable_load_avg, blocked_load_avg; >> > atomic64_t decay_counter, removed_load; >> > u64 last_decay; >> > -#endif /* CONFIG_FAIR_GROUP_SCHED */ >> > -/* These always depend on CONFIG_FAIR_GROUP_SCHED */ > We should perhaps replace this with a comment that these are only > needed to aggregate the point-wise representation in the > FAIR_GROUP_SCHED case. >
Is the comments ok? :)
/* runnable related variables only used in FAIR_GROUP_SCHED */
-- Thanks Alex
| |