Messages in this thread Patch in this message | | | Date | Tue, 07 May 2013 13:07:52 +0800 | From | Alex Shi <> | Subject | Re: [PATCH v5 2/7] sched: remove SMP cover for runnable variables in cfs_rq |
| |
On 05/06/2013 05:08 PM, Paul Turner wrote: >> > >> > >> > Do you mean to move the rq->avg and task_group->load_avg into CONFIG_SMP? > More generally: Why do we need them in !CONFIG_SMP? > > [ I was suggesting (potentially) using only rq->avg in the !CONFIG_SMP case. ] > >
Paul, here is the patch according to your opinions. any comments? :)
--- From 206957227ed899aa44fabeb9890117428103dd1e Mon Sep 17 00:00:00 2001 From: Alex Shi <alex.shi@intel.com> Date: Mon, 6 May 2013 22:20:29 +0800 Subject: [PATCH 2/7] sched: move few runnable tg variables into CONFIG_SMP
The following 2 variables only used under CONFIG_SMP, so better to move their definiation into CONFIG_SMP too.
atomic64_t load_avg; atomic_t runnable_avg;
Signed-off-by: Alex Shi <alex.shi@intel.com> --- kernel/sched/sched.h | 2 ++ 1 file changed, 2 insertions(+)
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h index 9419764..c6634f1 100644 --- a/kernel/sched/sched.h +++ b/kernel/sched/sched.h @@ -114,9 +114,11 @@ struct task_group { unsigned long shares; atomic_t load_weight; +#ifdef CONFIG_SMP atomic64_t load_avg; atomic_t runnable_avg; #endif +#endif #ifdef CONFIG_RT_GROUP_SCHED struct sched_rt_entity **rt_se; -- 1.7.12 -- Thanks Alex
| |